fix: standardization and refactor #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
chrisdholt,
EisenbergEffect and
janechu
as code owners
janechu
reviewed
Apr 24, 2020
packages/web-components/fast-components/src/text-field/text-field.template.ts
Show resolved
Hide resolved
packages/web-components/fast-components/src/utilities/apply-mixins.ts
Outdated
Show resolved
Hide resolved
janechu
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change standardizes implementations of classes, event dispatches, and several other clean up tasks.
Note - the following are technically breaking:
readonly->readOnlyonTextareacomponentbefore-content&after-content->start&endinTextfieldMotivation & context
This change combs through the components to leverage some of the newer features out of
@microsoft/fast-element. It also implements a mixin pattern for any component leveragingstart/endpatterns.Issue type checklist
Is this a breaking change?
Process & policy checklist