fix(fast-element): preserve observable values from before upgrade #2889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & context
When observable property values are set through the template engine, this happens before the elements have been upgraded. As a result, the property values shadow the observable property getter/setter, preventing observation. Additionally, if the element initialized the properties to a starting value, the initializers will overwrite the values provided by the template engine.
This PR captures values set by the template engine, deletes the shadowing properties, and then re-applies the bound values during the connect lifecycle.
Issue type checklist
As part of the fix, a new API was added to enable getting a list of all observed properties for an object. The naming
observedProperties
was chosen to mirror the web components naming ofobservedAttributes
.Process & policy checklist