Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fast-element): ensure host attributes have a target name #2846

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

EisenbergEffect
Copy link
Contributor

Description

Host attributes that don't have a special directive associated with them are missing their attribute name.

Motivation & context

This PR fixes a host attribute bug that was an oversight during the last revamp of how attribute and property binding works.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Next Steps

This particular bug and another one from earlier this week signals to me that we are far enough along where we need to get tests on the core library, so we can prevent regressions. Up until the last two weeks, various aspects of the library have been volatile enough that extensive tests would have slowed down the ability to revise and pivot quickly. I think we're past that point now and we need to get the infrastructure and some basic tests in place. Unless we have another urgent need, I plan to make that my next task.

@EisenbergEffect EisenbergEffect merged commit 4bd99c9 into master Mar 27, 2020
@EisenbergEffect EisenbergEffect deleted the users/eisenbergeffect/fix-host-attributes branch March 27, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants