fix(fast-element): ensure host attributes have a target name #2846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Host attributes that don't have a special directive associated with them are missing their attribute name.
Motivation & context
This PR fixes a host attribute bug that was an oversight during the last revamp of how attribute and property binding works.
Issue type checklist
Process & policy checklist
Next Steps
This particular bug and another one from earlier this week signals to me that we are far enough along where we need to get tests on the core library, so we can prevent regressions. Up until the last two weeks, various aspects of the library have been volatile enough that extensive tests would have slowed down the ability to revise and pivot quickly. I think we're past that point now and we need to get the infrastructure and some basic tests in place. Unless we have another urgent need, I plan to make that my next task.