Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update badges to resolve broken links #1816

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

awentzel
Copy link
Collaborator

@awentzel awentzel commented Jun 4, 2019

Description

Update badge markup for circle ci and lerna

Motivation & context

Lerna changed their domain which caused our badge to break. CircleCI seems to be case sensitive so that also broke that badge.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@awentzel awentzel self-assigned this Jun 4, 2019
@awentzel awentzel force-pushed the users/awentzel/update-badges branch 11 times, most recently from 055c7a0 to 35b1b75 Compare June 4, 2019 21:28
@awentzel awentzel force-pushed the users/awentzel/update-badges branch from f918b9a to e044df3 Compare June 4, 2019 23:59
@awentzel awentzel merged commit 0f89583 into master Jun 5, 2019
@awentzel awentzel deleted the users/awentzel/update-badges branch June 5, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants