feat: add directionSwitch for better localization composition #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 2449cdc and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.9% (0.1% change). View more on Code Climate. |
nalogiudice
reviewed
May 6, 2019
packages/fast-components-styles-msft/src/call-to-action/index.ts
Outdated
Show resolved
Hide resolved
nicholasrice
changed the title
nicholasrice
force-pushed
the
users/nirice/add-direction-switch
branch
3 times, most recently
from
9f9fad3 to
d6d6da2
Compare
janechu
approved these changes
May 7, 2019
janechu
reviewed
May 7, 2019
nalogiudice
approved these changes
May 8, 2019
nicholasrice
force-pushed
the
users/nirice/add-direction-switch
branch
3 times, most recently
from
62df191 to
d84e865
Compare
nicholasrice
force-pushed
the
users/nirice/add-direction-switch
branch
from
d84e865 to
3ab30b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
directionSwitchutility to pick a value based on a designSystem.direction value.closes #1738
Issue type checklist
Is this a breaking change?
Process & policy checklist