Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update codeowners to remove old packages and include fast-tooling-react #1624

Merged
merged 1 commit into from
Apr 7, 2019
Merged

chore: update codeowners to remove old packages and include fast-tooling-react #1624

merged 1 commit into from
Apr 7, 2019

Conversation

chrisdholt
Copy link
Member

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt force-pushed the users/chhol/update-codeowners-file branch from 8c287e2 to 3ba7986 Compare April 4, 2019 21:13
@chrisdholt chrisdholt force-pushed the users/chhol/update-codeowners-file branch from 3ba7986 to 91d251e Compare April 7, 2019 19:00
@codeclimate
Copy link

codeclimate bot commented Apr 7, 2019

Code Climate has analyzed commit 91d251e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.1% (0.0% change).

View more on Code Climate.

@chrisdholt chrisdholt merged commit 0fea1e9 into master Apr 7, 2019
@chrisdholt chrisdholt deleted the users/chhol/update-codeowners-file branch April 7, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awentzel awentzel awentzel approved these changes

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdholt @janechu @awentzel