Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listbox tests no longer spew warnings #1414

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Feb 21, 2019

Description

Listbox tests were spewing warnings about attaching elements to document body. Created a container and used that instead.

Motivation & context

Warnings are bad...

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@codeclimate
Copy link

codeclimate bot commented Feb 21, 2019

Code Climate has analyzed commit d67fad1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.4% (0.0% change).

View more on Code Climate.

@scomea scomea merged commit 75fe22a into master Feb 21, 2019
@scomea scomea deleted the users/scomea/listbox-test-fix branch February 21, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants