Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allows a oneOf with a nested object to be used #1386

Merged
merged 2 commits into from
Feb 15, 2019
Merged

fix: allows a oneOf with a nested object to be used #1386

merged 2 commits into from
Feb 15, 2019

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Feb 14, 2019

Description

Data with children could not have a nested oneOf that contained an object due to a navigational issue.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Feb 14, 2019
@janechu janechu force-pushed the users/janechu/fix-one-of-issue-with-nested-objects branch from 068f93a to 901c112 Compare February 15, 2019 20:22
@janechu janechu force-pushed the users/janechu/fix-one-of-issue-with-nested-objects branch from 901c112 to bdc0f96 Compare February 15, 2019 21:52
@codeclimate
Copy link

codeclimate bot commented Feb 15, 2019

Code Climate has analyzed commit bdc0f96 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.3% (0.0% change).

View more on Code Climate.

@janechu janechu merged commit db825a7 into master Feb 15, 2019
@janechu janechu deleted the users/janechu/fix-one-of-issue-with-nested-objects branch February 15, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalogiudice nalogiudice nalogiudice approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@janechu janechu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janechu @chrisdholt @nalogiudice