Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional functionality to listbox base #1381

Merged
merged 6 commits into from
Feb 20, 2019

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Feb 14, 2019

Description

  • add and implement autofocus and disabled props to listbox, these were found to needed to implement Select component
  • exposed some utility static functions. These are used by the Select component when it wants to manipulate selected items when the listbox is not actually instanciated.

Motivation & context

Towards a working select component

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@scomea scomea force-pushed the users/scomea/listbox-refine branch from beb4720 to dfb25c7 Compare February 14, 2019 18:18
@nalogiudice nalogiudice changed the title - feat: add additional functionality to listbox base feat: add additional functionality to listbox base Feb 14, 2019
@scomea scomea force-pushed the users/scomea/listbox-refine branch 2 times, most recently from d3de20d to fbb0b26 Compare February 18, 2019 20:38
@scomea scomea force-pushed the users/scomea/listbox-refine branch from fbb0b26 to aed8183 Compare February 19, 2019 23:14
@codeclimate
Copy link

codeclimate bot commented Feb 19, 2019

Code Climate has analyzed commit aed8183 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 4

The test coverage on the diff in this pull request is 76.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.3% (0.0% change).

View more on Code Climate.

@scomea scomea merged commit 48d9c31 into master Feb 20, 2019
@scomea scomea deleted the users/scomea/listbox-refine branch February 20, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants