Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add root level component navigation and ability to have string children #1372

Merged

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Feb 12, 2019

Description

Shows the text as the children string if children is a string, adds a root level expandable item.

Motivation & context

Changing the location requires a root level item and children can sometimes be strings and not components. This should resolve both of these issues.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Feb 12, 2019
@janechu janechu force-pushed the users/janechu/add-root-level-navigation-and-string-children branch from 0c02236 to 7281739 Compare February 12, 2019 02:49
@janechu janechu force-pushed the users/janechu/add-root-level-navigation-and-string-children branch from 7281739 to bf63207 Compare February 13, 2019 06:50
@codeclimate
Copy link

codeclimate bot commented Feb 13, 2019

Code Climate has analyzed commit bf63207 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (0.1% change).

View more on Code Climate.

@janechu janechu merged commit 2a8be6d into master Feb 14, 2019
@janechu janechu deleted the users/janechu/add-root-level-navigation-and-string-children branch February 14, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants