Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate export of viewer content base component #1358

Merged
merged 1 commit into from
Feb 4, 2019
Merged

fix: remove duplicate export of viewer content base component #1358

merged 1 commit into from
Feb 4, 2019

Conversation

chrisdholt
Copy link
Member

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt self-assigned this Feb 4, 2019
@chrisdholt chrisdholt requested a review from janechu February 4, 2019 18:38
@codeclimate
Copy link

codeclimate bot commented Feb 4, 2019

Code Climate has analyzed commit d9114b2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.4% (0.0% change).

View more on Code Climate.

@chrisdholt chrisdholt merged commit 1cd789a into master Feb 4, 2019
@chrisdholt chrisdholt deleted the users/chhol/fix-fast-viewer-build-failure branch February 4, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljefe223 eljefe223 eljefe223 approved these changes

@nalogiudice nalogiudice nalogiudice approved these changes

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

Assignees

@chrisdholt chrisdholt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @nicholasrice @janechu @nalogiudice @eljefe223