fix: ensure app build and tslint processes run prior in the build gate #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
previously approved these changes
Mar 24, 2018
awentzel
requested changes
Mar 26, 2018
nicholasrice
force-pushed
the
users/nirice/add-webpack-builds-to-build-gate
branch
from
614b2d4 to
418b8ed
Compare
awentzel
requested changes
Mar 26, 2018
CONTRIBUTING.md
Outdated
| @@ -168,7 +168,7 @@ Projects including intellectual property are only available for contributions by | |||
| For support: | |||
| + Submit [for help](https://stackoverflow.com/questions/tagged/fluent-web) | |||
| + Submit [feature requests](https://fluentweb.visualstudio.com/Fluent%20Web/_workitems?_a=new&witd=Feature) | |||
| + Submit [a bug](https://fluentweb.visualstudio.com/Fluent%20Web/_workitems/create/Bug) | |||
| + Submit [a bug](https://fluentweb.visualstudio.com/Fluent%20Web/_workitems/create/BuGg) | |||
There was a problem hiding this comment.
looks like a typo at the end of this sentence. Please revert this line from editing.
CONTRIBUTING.md
Outdated
| ``` | ||
|
|
||
| Each package in fast-dna has its own unique requirements and commands, but the following commands are relatively standard across all packages: |
There was a problem hiding this comment.
I would capitalize FAST-DNA since it's an acronym.
awentzel
previously approved these changes
Mar 26, 2018
chrisdholt
previously approved these changes
Mar 27, 2018
janechu
requested changes
Mar 27, 2018
CONTRIBUTING.md
Outdated
| ```shell | ||
| git clone https://github.com/Microsoft/fast-dna.git | ||
| cd fast-dna |
There was a problem hiding this comment.
still need to npm i for the root level packages
nicholasrice
force-pushed
the
users/nirice/add-webpack-builds-to-build-gate
branch
from
cd57047 to
9130d96
Compare
janechu
approved these changes
Mar 27, 2018
chrisdholt
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #133