docs: updates developer documentation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested changes
Mar 23, 2018
| ## Governance | ||
| ### Steering Committee | ||
| The Fluent Web Steering Committee ("Steering Committee"), membership consists of key Fluent Web Collaborators ("Collaborators") who have demonstrated both design and technical expertise critical to the ongoing support, maintenance, evolution, and a long term commitment to driving the project and community forward. |
There was a problem hiding this comment.
This paragraph (and elsewhere) should probably not reference FW in the mono-repo.
There was a problem hiding this comment.
I considered changing this, however, it directly aligns with sharing names with our security and user group policy so I want to keep for now.
|
|
||
| ### Owners | ||
| Fluent Web Owners ("Owners"), having 'admin' access, have ultimate authority and are responsible for management, maintainenance, and operations of repositories. |
There was a problem hiding this comment.
Should we reference FW here? Seems like this would be specific to the -msft package
|
|
||
| ### Collaborators | ||
| Fluent Web Collaborators ("Collaborators"), having 'write' access, have major impact on the project and participate in triaging issues, reviewing code, mentoring, and working to improve and maintain overall architecutural quality. |
|
|
||
| ### Contributors | ||
| Fluent Web Contributors ("Contributors"), having 'read' access, can be any individual who have shown interest by contributing a pull request to the project. |
README.md
Outdated
|
|
||
|
|
||
| #### FAST JSS manager | ||
| A React higher order component (HOC) library for managing component JSS stylesheets. [Readme](https://github.com/Microsoft/fast-dna/tree/master/packages/fast-jss-manager-react) |
There was a problem hiding this comment.
should 'higher order' be hyphenated?
chrisdholt
previously approved these changes
Mar 23, 2018
chrisdholt
approved these changes
Mar 24, 2018
nicholasrice
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details on formatting pull requests.