-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update the pull request template and documentation #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falkicon
requested review from
awentzel,
chrisdholt,
janechu,
nalogiudice and
nicholasrice
as code owners
December 24, 2018 03:06
janechu
requested changes
Dec 26, 2018
nicholasrice
approved these changes
Dec 26, 2018
janechu
force-pushed
the
users/jasfalk/pull_request_template_2
branch
from
December 26, 2018 23:03
51f5f47
to
545f6d5
Compare
janechu
approved these changes
Dec 26, 2018
Code Climate has analyzed commit 545f6d5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.4% (0.0% change). View more on Code Climate. |
Falkicon
added a commit
that referenced
this pull request
Dec 27, 2018
* Updated content for README.MD Updated/edited content and added logo. More changes coming soon but this fixes some larger issues with messaging. * Update README.md * Update issue templates (#1225) * Update issue templates I have simplified the templates and made them more consistent. Also deleted a placeholder template we were not using. * Update report-a-bug.md * Delete Bug_report.md * Delete Feature_request.md * Update README.md * fix: updated component readme.md files to be more consistent (#1232) * fix: updated description * fix: updated consistency across readme files as a first pass * removed package.json which should not be part of this commit * package.json * reset package.json * Update README.md * added display names for components in fast layouts (#1221) * chore: style changes for documentation web sites, fixed focus, responsive, loc, and other touches; update does not address content (#1233) * fix: updated description * removed package.json which should not be part of this commit * package.json * reset package.json * additional updates to style and structure on documentation site * Style updates for documentation web sites, also fixed focus, responsive, loc, and other touches; update does not address content * added display names for components in fast layouts (#1221) * fix: updated description * removed package.json which should not be part of this commit * package.json * reset package.json * additional updates to style and structure on documentation site * Style updates for documentation web sites, also fixed focus, responsive, loc, and other touches; update does not address content * class to className change and extra comments in css * fix: updated description (#1231) * chore: update the pull request template and documentation (#1230) * chore: update the pull request template and documentation * chore: update the pull request template and documentation * Updates based on pr comments * move file to appropriate directory * Updated content for README.MD Updated/edited content and added logo. More changes coming soon but this fixes some larger issues with messaging. * Update README.md * Update README.md * Update README.md * Updated lerna link per PR request * Updated content for README.MD Updated/edited content and added logo. More changes coming soon but this fixes some larger issues with messaging. * Update README.md * Update README.md * Update README.md * Updated content for README.MD Updated/edited content and added logo. More changes coming soon but this fixes some larger issues with messaging. * Update README.md * Update README.md * formatting changes in .MD and update of Lerna URL * Updated lerna link per PR request * updated md formatting and lerna link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.