Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update render prop to correct broken action trigger examples #1194

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Dec 7, 2018

bug: Fix broken examples for action trigger.

Action trigger sample data missing a glyph element. Use a cleaner version of svg glyph.

fixes #1193

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your PR title to align to our standards?

Likely:

fix: update render prop to correct broken action trigger examples

@scomea scomea changed the title bug: fix broken examples for action trigger fix: update render prop to correct broken action trigger examples Dec 7, 2018
@codeclimate
Copy link

codeclimate bot commented Dec 10, 2018

Code Climate has analyzed commit ee4bbea and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.2% (0.0% change).

View more on Code Climate.

@scomea scomea merged commit 9bd324c into master Dec 10, 2018
@scomea scomea deleted the users/scomea/action-trigger-examples-fix branch January 4, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action trigger examples broken
4 participants