fix: ensure setAttribute is not called during construction (#3523)

microsoft · Jul 16, 2020 · a0b8658 · a0b8658
1 parent b40365c
commit a0b8658
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/packages/web-components/fast-components-msft/src/anchor/index.ts b/packages/web-components/fast-components-msft/src/anchor/index.ts
@@ -37,7 +37,7 @@ export class FASTAnchor extends Anchor {
      * HTML Attribute: appearance
      */
     @attr
-    public appearance: AnchorAppearance = "neutral";
+    public appearance: AnchorAppearance;
     public appearanceChanged(
         oldValue: AnchorAppearance,
         newValue: AnchorAppearance
@@ -47,4 +47,15 @@ export class FASTAnchor extends Anchor {
             this.classList.remove(oldValue);
         }
     }
+
+    /**
+     * @internal
+     */
+    public connectedCallback() {
+        super.connectedCallback();
+
+        if (!this.appearance) {
+            this.appearance = "neutral";
+        }
+    }
 }
diff --git a/packages/web-components/fast-components-msft/src/button/index.ts b/packages/web-components/fast-components-msft/src/button/index.ts
@@ -41,7 +41,7 @@ export class FASTButton extends Button {
      * HTML Attribute: appearance
      */
     @attr
-    public appearance: ButtonAppearance = "neutral";
+    public appearance: ButtonAppearance;
     public appearanceChanged(
         oldValue: ButtonAppearance,
         newValue: ButtonAppearance
@@ -51,4 +51,15 @@ export class FASTButton extends Button {
             this.classList.remove(oldValue);
         }
     }
+
+    /**
+     * @internal
+     */
+    public connectedCallback() {
+        super.connectedCallback();
+
+        if (!this.appearance) {
+            this.appearance = "neutral";
+        }
+    }
 }