-
Notifications
You must be signed in to change notification settings - Fork 595
Update Japanese translations in localization.rs
#100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm sorry to say (even being Japanese) I have to object most of your proposal.
|
"Do you want to send it anyway?"I proposed adding "本当に" ("really") to make the confirmation sound stronger, but on second thought it doesn't seem truly necessary. -- "Reopen with encoding"You're right that phrasing it as “エンコーディングして...” could be misread as "encode first, then reopen." However, I still find "エンコーディングで開く" hard to accept.
I would like to offer two alternatives: (1) "指定エンコーディングで再度開く" (2) "エンコード付きで再度開く" That said, I prefer option (1), which makes the user's action more explicit. -- しかし、やはり「エンコーディングで開く」というのが私には受け入れられません。
代替案として2つ提示します: (1) "指定エンコーディングで再度開く" (2) "エンコード付きで再度開く" よりユーザの行動を明に示した (1) 案のほうが、私はよりよいと考えています。 |
|
Is there agreement between you all about the spelling? Unfortunately, I cannot properly judge the correctness of the suggestion as I rely on machine translations. |
|
Regarding the following two, I am against this PR. I am a native Japanese speaker, living in Japan. "Reopen with encoding" In both cases, the PR keeps the word "エンコーディング", which is the direct translation of the word "encoding". I am against this word because we used to use "文字コード" historically. I have sent PR #232 based on this opinion. |
|
@suikan4github |
lhecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this for now and we can still refine this later if you'd like. Thank you for your work, everyone!
Description
This PR tweaks the Japanese strings to better reflect the original English prompts:
“Do you want to send it anyway?”それでも送信しますか?→本当に送信しますか?“Reopen with encoding”
エンコーディングで再度開く→エンコーディングして再度開くエンコーディングで再度開く→指定エンコーディングで再度開く“Convert to encoding”
エンコーディングに変換→エンコーディングを変換