Repository navigation
fix(build): clear high-severity grype findings on main - #839
Merged
Merged
Conversation
- override basic-ftp to ^6.2.2 for GHSA-c475-qrg2-pj4r in link-check tooling - align root npm overrides and resolutions with basic-ftp ^6.2.2 - add scoped grype ignores for unfixed braces and http-cache-semantics advisories 🔒 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged
14 tasks done
Marcel Bindseil (bindsi)
approved these changes
Oct 5, 2026
Allen Greaves (agreaves-ms)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
maincurrently fails the Grype step of the Security Scan job, which fails the requiredPR Validation Gateon unrelated PRs (for example #831, #834, #825, #824, #797, and #786). Running Grype 0.109.1 with.grype.yamlagainstmain(128cd7ae) reports three findings at or above thehighthreshold:basic-ftp.github/scripts/markdown-link-check/package-lock.jsonbracesdocs/docusaurus/package-lock.jsonhttp-cache-semanticsdocs/docusaurus/package-lock.jsonThis PR remediates the fixable finding and documents the two unfixable ones.
Related Issue
Relates to #831
Type of Change
Implementation Details
basic-ftpoverrideget-uri(8.0.1) still requiresbasic-ftp ^5.3.1, so there is no upstream upgrade path.overridesentry forbasic-ftp: ^6.2.2in.github/scripts/markdown-link-check/package.jsonand updated the existing rootoverridesandresolutionsfrom^5.3.0to^6.2.2. 6.2.2 also fixes GHSA-5rfr-xx34-2xxv.get-urionly callsaccess,lastMod,list,downloadTo, andclose. The only 6.0.0 breaking change disables separate transfer hosts by default to prevent FTP bounce attacks; none of these call sites depend on it.basic-ftpentry in each lockfile.Scoped Grype ignores
Both advisories have no patched release. The ignores follow the existing
image-sizeprecedent and are scoped by package type and name:braces(GHSA-vfj7-8cjw-p6xm): reached through Docusaurus build-time file watching and glob matching (chokidar,micromatch) with repository-controlled patterns.http-cache-semantics(GHSA-ch52-4w7c-c8xp): reached only through Docusaurus's update notifier (update-notifier→latest-version→package-json→got→cacheable-request), a single-user CLI version check. The repository does not run a shared HTTP cache.Both ignores should be removed when patched releases are available.
Testing Performed
.grype.yaml(same version and config as CI)Validation Steps
grype dir:. --config .grype.yamlonmain: exit 2 with the three high findings above.yamllint -c .yamllint.yml .grype.yaml: pass.npm ci --prefix .github/scripts/markdown-link-checkinstallsbasic-ftp6.2.2, andmarkdown-link-checkruns and checks links normally.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review
Additional Notes
No Terraform, Bicep, or application code changes. The two Grype ignores are risk acceptances and need maintainer review.