Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ebpf_verify_program API #997

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Conversation

Alan-Jowett
Copy link
Member

@Alan-Jowett Alan-Jowett commented Apr 22, 2022

Signed-off-by: Alan Jowett alan.jowett@microsoft.com

Description

eBPF-For-Windows only support in-proc verification only of eBPF programs. Verification and load is the only exposed service from eBpfService.

Testing

Removed code.

Documentation

Updated docs.

Resolves: #981

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #997 (3ea57c4) into main (6bc0a6b) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 3ea57c4 differs from pull request most recent head f5899ed. Consider uploading reports for the commit f5899ed to get more accurate results

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   85.14%   85.24%   +0.10%     
==========================================
  Files          96       96              
  Lines       15174    15149      -25     
==========================================
- Hits        12920    12914       -6     
+ Misses       2254     2235      -19     
Impacted Files Coverage Δ
ebpfapi/rpc_client.cpp 48.97% <ø> (+5.34%) ⬆️
libs/service/api_service.cpp 79.41% <ø> (+6.76%) ⬆️
tests/end_to_end/test_helper.cpp 86.53% <0.00%> (-2.70%) ⬇️
libs/platform/ebpf_pinning_table.c 86.55% <0.00%> (-0.54%) ⬇️
libs/execution_context/ebpf_maps.c 86.59% <0.00%> (-0.11%) ⬇️
libs/execution_context/ebpf_core.c 88.16% <0.00%> (+0.11%) ⬆️
libs/execution_context/ebpf_program.c 78.23% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc0a6b...f5899ed. Read the comment docs.

dthaler
dthaler previously approved these changes Apr 22, 2022
Alan Jowett added 5 commits April 25, 2022 09:07
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@Alan-Jowett Alan-Jowett merged commit 1989d26 into microsoft:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libs/service/api_service.cpp / ebpf_verify_program
3 participants