-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sock addr hook #871
Sock addr hook #871
Conversation
This reverts commit c542c6c.
Codecov Report
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 75.28% 75.32% +0.04%
==========================================
Files 83 83
Lines 14614 14606 -8
Branches 488 482 -6
==========================================
Hits 11002 11002
+ Misses 3321 3313 -8
Partials 291 291
Continue to review full report at Codecov.
|
dfc5972
to
2e69dd0
Compare
2a5b65d
to
24094a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't block this one, but in general it is bad practice to put tests in a separate PR. Instead, in the future look for other ways to factor the PR into smaller pieces where each smaller piece contains a test. For example, the function signature changes could have been in a separate PR from the sock addr additions.
Understood. This was indeed tested but the automation was not made part of this PR as otherwise I would have to pull in other code and would make it a long PR to review. There is still an unresolved comment where I have asked a question to you. Please answer and/or resolve. |
29b6e48
to
126d3a6
Compare
126d3a6
to
0805949
Compare
Description
This is the second part of changes for #847 .
This change adds
net_ebpf_ext_sock_addr.c
file that holds the program info and hook NPI providers for sock_addr hook. It also has an empty implementation of the classify callback for WFP callouts added for this hook.net_ebpf_extension_xdp_on_client_attach
was refactored into a utility functionnet_ebpf_extension_hook_check_attach_parameter
that is common to sock_addr hook type as well.Testing
No new tests have been added. They will be added in the next iteration of the changes.
Documentation
Doxygen comments.