Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle map concurrency in test_helper. #2319

Merged

Conversation

gtrevi
Copy link
Collaborator

@gtrevi gtrevi commented Apr 13, 2023

Fixes #2318

Description

This PR adds concurrency handling in the test_pelper when accessing the _fd_to_handle_map and _service_path_to_context_map maps.

Testing

CI/CD

Documentation

n.a.

@gtrevi gtrevi marked this pull request as ready for review April 13, 2023 06:35
Alan-Jowett
Alan-Jowett previously approved these changes Apr 13, 2023
dthaler
dthaler previously approved these changes Apr 13, 2023
@dthaler dthaler added this pull request to the merge queue Apr 13, 2023
@dthaler dthaler added bug Something isn't working tests labels Apr 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 13, 2023
@dthaler dthaler enabled auto-merge April 13, 2023 22:31
saxena-anurag
saxena-anurag previously approved these changes Apr 14, 2023
tests/end_to_end/test_helper.cpp Outdated Show resolved Hide resolved
@gtrevi gtrevi dismissed stale reviews from saxena-anurag, dthaler, and Alan-Jowett via bbe10dd April 14, 2023 04:33
@dthaler dthaler added this pull request to the merge queue Apr 14, 2023
Merged via the queue into microsoft:main with commit 3b86a71 Apr 14, 2023
@gtrevi gtrevi deleted the gtrevi/fix-concurrency-handling-test_helper branch April 27, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add concurrency handling in test_helper.cpp
4 participants