Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate post-merge feedback #2027

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Incorporate post-merge feedback #2027

merged 2 commits into from
Feb 3, 2023

Conversation

dv-msft
Copy link
Contributor

@dv-msft dv-msft commented Feb 3, 2023

Description

This PR addresses the post-merge feedback for the 'circular references fix' PR

Testing

User mode:

  • Ensure that the unit_tests.exe test suite passes successfully.

Kernel Mode:

  • Ensure that the api_test.exe test suite passes successfully, multiple times back-to-back.
  • The epbfcore.sys driver can be unloaded and re-loaded successfully after a multiple pass test run.

Documentation

No new documentation required.

Fixes: #1509 #1510

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #2027 (5b24ef5) into main (f50dcb9) will increase coverage by 2.87%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
+ Coverage   82.65%   85.52%   +2.87%     
==========================================
  Files         152      148       -4     
  Lines       27547    26344    -1203     
==========================================
- Hits        22768    22532     -236     
+ Misses       4779     3812     -967     
Impacted Files Coverage Δ
libs/platform/ebpf_object.c 79.16% <0.00%> (ø)
netebpfext/net_ebpf_ext_xdp.c 53.95% <42.10%> (-0.31%) ⬇️
libs/execution_context/ebpf_maps.c 90.57% <80.00%> (ø)
libs/thunk/windows/platform.cpp 12.29% <0.00%> (-62.30%) ⬇️
tests/libs/util/service_helper.cpp 38.88% <0.00%> (-10.03%) ⬇️
tests/sample/ext/app/sample_ext_app.cpp 92.59% <0.00%> (-6.00%) ⬇️
ebpfapi/rpc_client.cpp 53.57% <0.00%> (-2.57%) ⬇️
tests/libs/util/socket_helper.cpp 47.05% <0.00%> (-2.32%) ⬇️
tests/libs/common/common_tests.cpp 92.38% <0.00%> (-1.91%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dv-msft dv-msft marked this pull request as ready for review February 3, 2023 20:12
@dthaler dthaler enabled auto-merge (squash) February 3, 2023 22:42
@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Feb 3, 2023
@dthaler dthaler merged commit fd1bd43 into microsoft:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BPF_MAP_TYPE_PROG_ARRAY permits circular references
3 participants