Clean up order of includes #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
Alan-Jowett
previously approved these changes
Feb 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 82.41% 83.98% +1.57%
==========================================
Files 141 149 +8
Lines 25402 27160 +1758
==========================================
+ Hits 20935 22811 +1876
+ Misses 4467 4349 -118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fixes microsoft#1963 Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
The generate script does not handle this file. Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dv-msft
approved these changes
Feb 6, 2023
| #include <malloc.h> | ||
| #include <sddl.h> | ||
|
|
||
| #include "rpc_interface_s.c" |
There was a problem hiding this comment.
nit: Since we have an exception here (that rpc_interface_s.c is included after svc_common.h), should we add a comment in the file mentioning this is deliberate?
There was a problem hiding this comment.
It's not an exception per se, since this is including a C file not a header. DevelopmentGuide.md says:
DO include local headers (with
"") before system headers (with<>).
Line 60 of .clang-format explicitly puts C files after headers.
Alan-Jowett
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1963
Signed-off-by: Dave Thaler dthaler@microsoft.com
Testing
No impact.
Documentation
This PR includes doc updates.