Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about WDK vsix checkbox when installing WDK #1327

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

dthaler
Copy link
Collaborator

@dthaler dthaler commented Aug 9, 2022

Signed-off-by: Dave Thaler dthaler@microsoft.com

Description

Fixes #1196

Testing

N/A

Documentation

This is a doc-only change

@dthaler dthaler added the documentation Improvements or additions to documentation label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1327 (7098787) into main (c97b2a7) will increase coverage by 3.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   83.82%   87.35%   +3.53%     
==========================================
  Files         120      108      -12     
  Lines       20833    18796    -2037     
==========================================
- Hits        17464    16420    -1044     
+ Misses       3369     2376     -993     
Impacted Files Coverage Δ
libs/thunk/windows/platform.cpp 4.91% <0.00%> (-63.94%) ⬇️
libs/platform/ebpf_program_types.c 0.00% <0.00%> (-50.00%) ⬇️
ebpfapi/rpc_client.cpp 48.97% <0.00%> (-7.03%) ⬇️
libs/api/libbpf_program.cpp 76.92% <0.00%> (-4.00%) ⬇️
tests/libs/common/common_tests.cpp 91.91% <0.00%> (-2.03%) ⬇️
tests/end_to_end/test_helper.cpp 89.40% <0.00%> (-1.99%) ⬇️
libs/api/ebpf_api.cpp 84.98% <0.00%> (-0.51%) ⬇️
x64/Debug/ElfWrapper.c
tests/bpftool_tests/bpftool_tests.cpp
tests/libs/util/service_helper.h
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…the WDK

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler dthaler force-pushed the wdk-vsix branch 2 times, most recently from 782ba22 to d6b7e8b Compare August 10, 2022 00:01
@dthaler dthaler merged commit 64f8b4d into microsoft:main Aug 15, 2022
@dthaler dthaler deleted the wdk-vsix branch August 15, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started guide's script fails to install wdk.vsix and spectre libraries
3 participants