Build ELF parse at compile time using EverParse #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 88.38% 86.58% -1.80%
==========================================
Files 108 111 +3
Lines 18242 18651 +409
==========================================
+ Hits 16123 16149 +26
- Misses 2119 2502 +383
Continue to review full report at Codecov.
|
|
@shankarseal when you get a chance, could you please create a CMakeLists.txt file to build the spec.lib? I was unable to get cmake to build it correctly. |
dthaler
reviewed
Jun 15, 2022
dthaler
reviewed
Jun 15, 2022
dthaler
previously approved these changes
Jun 16, 2022
dthaler
previously approved these changes
Jun 17, 2022
shankarseal
reviewed
Jun 20, 2022
shankarseal
previously approved these changes
Jun 20, 2022
added 3 commits
June 20, 2022 15:23
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
dthaler
approved these changes
Jun 20, 2022
shankarseal
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invoke the Everparse generated validation prior to parsing the ELF file.
Testing
CI/CD
Documentation
NO
Resolves: #834