-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rewinding orchestrations #96
Conversation
Thanks for this contribution! I did a quick scan of the changes and I don't have any issues with your approach. In the fullness of time, we're thinking of changing how we implement rewind to be storage provider-agnostic, but I think this implementation should be good enough for a preview-quality feature until we get around to a more generic overhaul. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts:
I think I took care of your current comments. It's a great thing that Rewind is being worked on, to me it is a key feature of durable functions! Even better if it can be done in a storage-agnostic way! |
In an effort to make some small changes to your PR, it seems I've accidentally also merged in the latest from the main branch. Sorry about the noise it's causing on this PR. I'm basically good with these changes and will just do a few manual tests before signing off and merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for this contribution!
Should fix #66.
I tried to mimic as much as possible the table storage implementation.
However, I'm pretty sure there is lot of room for improvement, so please don't hesitate to tell me where, and I'll try to enhance the proposal.
Known limitation: