Fix purge history threshold check #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
approved these changes
Jul 19, 2021
|
Looks like we have some tests that assume the previous behavior that also need to be updated in order for the CI to pass. |
Update CHANGELOG with change details
|
|
|
I went ahead and added the appropriate test updates to your PR. I also credited you with this contribution in the CHANGELOG. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
PurgeOrchestrationHistoryAsyncsays it should be purging instances that are older than the given threshold. However it seems that the stored procedure used to retrieve these is currently retrieving instances newer than the given threshold.This will PR fixes the
PurgeInstanceStateByTimestored procedure to retrieve instances that are older than the given threshold time.