Quick fix for sub-orchestration gRPC serialization issue #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
The issue is specific to protobuf/gRPC serialization of history events used by Azure Functions .NET Isolated and Java. There was a
nullplaceholder value forSubOrchestrationInstanceCreatedEvent.InstanceId, which was not compatible with the protobuf contract. The quick fix is to use""instead ofnull.There is a potentially larger fix, which is to correctly rehydrate the instance ID value for this history event, but this would require a database schema change, which is a much more expensive process. Per testing, the workaround in this PR should be sufficient to unblock basic sub-orchestration usage.