Synchronous reads for improved performance for large payloads #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Jan 10, 2023
bhugot
force-pushed
the
temp_execute_synchronously
branch
from
4d27541
to
3d0ddbb
Compare
|
@cgillum a new version is coming as my fix was incorrect the performance issue what on the reader and not on ExecuteReaderAsync I let a first run to show the test performance (on my computer it was around 1 min 40 and after the fix it was 12sec) |
added 4 commits
January 27, 2023 18:07
bhugot
force-pushed
the
temp_execute_synchronously
branch
from
6479b38
to
1bb76f4
Compare
|
@bhugot I just verified your fix on my machine: your stress test takes 1.1 minutes without the fix and is 4.5 seconds with your fix. That's pretty incredible! |
|
:) |
cgillum
changed the title
|
It's ok for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on because of mssql client async bug sqlcli
It should be easy to switch back when the fix is done
It should also fix #126