Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upgrade test infrastructure #130

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Added upgrade test infrastructure #130

merged 8 commits into from
Sep 29, 2023

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Oct 31, 2022

Resolves #124
Resolves #191

This PR introduces a tool for generating SQL databases with data from the v1.0.0 release of the SQL provider as well as a new test that restores the generated database and runs tests against it. This is necessary to ensure that databases can be auto-upgraded and that no data loss occurs as part of the upgrade.

@keerthikiranvalathoru
Copy link

This is quite simple yet very powerful suite of tests. I was browsing through the code for some other things and and found this gem of a PR that is a template on how to have database compatibility and upgrade tests. Thanks very much !

Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some thoughts and questions 🦖

@cgillum cgillum linked an issue Sep 29, 2023 that may be closed by this pull request
@cgillum cgillum requested a review from bachuv September 29, 2023 18:46
Copy link
Contributor

@bachuv bachuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema-1.2.0.sql changes make sense to me. Thanks for adding the description that explains how to find the stored procedure dependencies!

src/DurableTask.SqlServer/Scripts/schema-1.2.0.sql Outdated Show resolved Hide resolved
@cgillum cgillum merged commit f561931 into main Sep 29, 2023
2 checks passed
@cgillum cgillum deleted the cgillum/upgrade-testing branch September 29, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App fails to start up when upgrading from 1.0.0 to 1.2.0 schema Database upgrade testing
4 participants