Update dependencies, ESLint configuration, and add pull request template#81
Merged
YunchuWang merged 4 commits intomainfrom Feb 2, 2026
Merged
Update dependencies, ESLint configuration, and add pull request template#81YunchuWang merged 4 commits intomainfrom
YunchuWang merged 4 commits intomainfrom
Conversation
added 2 commits
January 30, 2026 17:04
- Updated ESLint and Prettier dependencies in package.json for improved linting and formatting. - Removed specific file extensions from ESLint linting command to simplify usage. - Added new ESLint configuration file (eslint.config.mjs) with custom rules and settings. - Refactored TypeScript imports to use ES module syntax and removed unnecessary require statements. - Enhanced error handling and logging in TaskHubGrpcClient methods. - Cleaned up code by removing commented-out sections and unused variables. - Deleted deprecated TaskHubGrpcWorker class to streamline the codebase. - Updated TypeScript configuration to include baseUrl for module resolution.
There was a problem hiding this comment.
Pull request overview
This PR modernizes linting/tooling, updates dependencies, and streamlines internal structure by centralizing imports on the published @microsoft/durabletask-js package and adding a standardized pull request template.
Changes:
- Replace legacy ESLint config (
.eslintrc.json/.eslintignore) with a flat-config-basedeslint.config.mjsand update related dev dependencies and scripts. - Consolidate imports to
@microsoft/durabletask-js, clean up types and logging, and add small robustness improvements (e.g., safer stack trace handling). - Add a PR template and update the durabletask protobuf submodule reference.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| submodules/durabletask-protobuf | Updates the durabletask protobuf submodule reference to a new commit. |
| src/worker/task-hub-grpc-worker.ts | Removes the legacy worker implementation from the old src layout, likely superseded by the packages/durabletask-js implementation. |
| packages/durabletask-js/src/worker/registry.ts | Adds an ESLint suppression to allow using Function in _getFunctionName under the new lint rules. |
| packages/durabletask-js/src/worker/activity-executor.ts | Simplifies activity completion logging to avoid dumping full outputs while still logging payload size. |
| packages/durabletask-js/src/utils/pb-helper.util.ts | Makes failure detail stack trace handling more robust when e.stack is undefined. |
| packages/durabletask-js/src/task/index.ts | Adds an ESLint suppression for the Function-typed getName helper. |
| packages/durabletask-js/src/client/client.ts | Simplifies error handling in wait-for-instance methods by removing redundant try/catch wrappers around promise races. |
| packages/durabletask-js-azuremanaged/tsconfig.build.json | Sets baseUrl for proper path mapping to the @microsoft/durabletask-js dist output. |
| packages/durabletask-js-azuremanaged/src/worker-builder.ts | Switches to importing worker and function types directly from @microsoft/durabletask-js rather than local type aliases. |
| packages/durabletask-js-azuremanaged/src/user-agent.ts | Cleans up a now-unnecessary ESLint suppression around require("../package.json"). |
| packages/durabletask-js-azuremanaged/src/options.ts | Removes now-unnecessary ESLint suppressions around require usage for os and crypto. |
| package.json | Updates dev dependency versions (ESLint, Prettier, TypeScript-ESLint, etc.) and simplifies the lint script for the new flat config. |
| examples/hello-world/human_interaction.ts | Updates the example to import from the @microsoft/durabletask-js package instead of local source paths. |
| examples/hello-world/fanout-fanin.ts | Same as above: centralizes imports on @microsoft/durabletask-js. |
| examples/hello-world/activity-sequence.ts | Same as above: centralizes imports on @microsoft/durabletask-js. |
| eslint.config.mjs | Introduces a flat ESLint config using @eslint/js, typescript-eslint, and globals, with updated rules and ignore patterns. |
| .github/PULL_REQUEST_TEMPLATE.md | Adds a structured PR template including AI-assistance disclosure and testing checklist. |
| .eslintrc.json | Removes the legacy ESLint configuration in favor of the new flat config. |
| .eslintignore | Removes the legacy ESLint ignore file, with ignore patterns now encoded in eslint.config.mjs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YunchuWang
reviewed
Feb 2, 2026
.eslintignore
Outdated
Member
There was a problem hiding this comment.
good catch, this is the recommended way to put this in eslint.config
YunchuWang
reviewed
Feb 2, 2026
YunchuWang
reviewed
Feb 2, 2026
YunchuWang
reviewed
Feb 2, 2026
submodules/durabletask-protobuf
Outdated
YunchuWang
approved these changes
Feb 2, 2026
YunchuWang
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
eslint.config.mjs)typescript-eslintv8.54.0pb-helper.util.ts(e.stack?.toString() ?? "")client.tsactivity-executor.tsworker-builder.tsto use package exports instead ofanysrc/worker/task-hub-grpc-worker.tsbaseUrlto azuremanaged packageWhy is this change needed?
Issues / work items
Project checklist
AI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
Notes for reviewers
src/worker/task-hub-grpc-worker.tswas stale and used an olderpromisifypattern vs the currentcallWithMetadataapproach.mjsextension to avoid module warning)