Improve logging for unexpected connection failures in DurableTaskGrpcWorker #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failures in DurableTaskGrpcWorker
kaibocai
approved these changes
Apr 29, 2025
nytian
reviewed
Apr 29, 2025
| logger.log(Level.INFO, "Durable Task worker has disconnected from {0}.", this.getSidecarAddress()); | ||
| } else { | ||
| logger.log(Level.WARNING, "Unexpected failure connecting to {0}.", this.getSidecarAddress()); | ||
| logger.log(Level.WARNING, String.format("Unexpected failure connecting to %s", this.getSidecarAddress()), e); |
There was a problem hiding this comment.
Is it okay to just log e like that? Shouldn’t we be logging e.Message instead? Or, if the intention is to log the exception type, shouldn’t that come first rather than at the end?
JoshVanL
pushed a commit
to JoshVanL/durabletask-java
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information