This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Switch to FxCop analyzers #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the the deprecated fxcop task in favor of running the newer fxcop Roslyn analyzers.
In fact the new fxcop roslyn analyzers are already running in this repo, as brought in by Directory.Build.targets. It's not the latest version, but updating it can happen sometime after we update the SDK we're using since right now, analyzer warnings aren't even showing up in VS.
I do fix a few issues that came up when updating the fxcop analyzer version temporarily though.
I also remove the special steps that "Run Roslyn Analyzers". I don't know what that task is meant to do, but roslyn analyzers run as part of the build, and this task not only repeats that to some extent, it also repeats the package restore and build to some extent. It also fails for virtually every PR (all unrelated), so removing it allows us to move forward.