This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fixing FxCop issues #567
Merged
Fixing FxCop issues #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
conniey
commented
Jan 31, 2018
•
conniey
commented
- Fixing CA3053 issues with XmlSecureResolver
- Fixing globalisation issues with interpolated strings
* For each FormattableString, specify a culture or invariant * Suppress CA3053 because of the false positives
twsouthwick
approved these changes
Jan 31, 2018
| @@ -114,7 +115,9 @@ private void Load(Stream stream, string path) | |||
| XmlResolver = null | |||
| }; | |||
|
|
|||
| schemas.Add(null, XmlReader.Create(xsdStream, xmlReaderSettings)); | |||
| var reader = XmlReader.Create(xsdStream, xmlReaderSettings); | |||
There was a problem hiding this comment.
this should be disposed, but not a blocker for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.