Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix issue where Autofac cannot resolve IApiPortService #546

Merged
merged 3 commits into from
Jan 12, 2018
Merged

Fix issue where Autofac cannot resolve IApiPortService #546

merged 3 commits into from
Jan 12, 2018

Conversation

conniey
Copy link
Member

@conniey conniey commented Jan 12, 2018 •
edited
Loading

  • Console tool could not resolve ApiPortClient for commands other than analyze and dump because IApiPortService was not registered.
  • This always registers ApiPortService if the command is not dump
  • This also updates some READMEs that had broken links and makes it more concise. Hopefully

twsouthwick
twsouthwick approved these changes Jan 12, 2018
View reviewed changes
docs/VSExtension/README.md
[VSGallery]: https://marketplace.visualstudio.com/items?itemName=ConnieYau.NETPortabilityAnalyzer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this released under your name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's because it had to belong to a personal MSDN account and we don't have a team account. So it was moved to me.

@conniey conniey merged commit 6661e5c into microsoft:dev Jan 12, 2018
@conniey conniey deleted the fixConsoleIssue branch January 12, 2018 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twsouthwick twsouthwick twsouthwick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conniey @twsouthwick