Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add excel writer #467

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Add excel writer #467

merged 2 commits into from
Sep 15, 2017

Conversation

twsouthwick
Copy link
Member

Now that DocumentForma.OpenXml is availalbe, we can put our excel writer here.

conniey
conniey suggested changes Sep 2, 2017
View reviewed changes
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a nuspec for this to generate a NuGet package... I think to upgrade the service, we'd have to generate a package and push it to our NuGet feed.

@twsouthwick
Copy link
Member Author

@conniey I've got a PR that will simplify the packaging (included in #475), so I'd rather wait to incorporate the package creation there. If that's okay, once it's merged, I'll update that PR

@twsouthwick
Copy link
Member Author

@conniey I've rebased against my changes for PackageReference so now the nupkg is generated for this library

conniey
conniey approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twsouthwick twsouthwick merged commit 21d0461 into microsoft:master Sep 15, 2017
@twsouthwick twsouthwick deleted the excel-writer branch September 15, 2017 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@conniey conniey conniey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twsouthwick @conniey @msftclas