Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Update ApiPort.Core to .NET Core App #332

Merged
merged 5 commits into from
Oct 3, 2016

Conversation

conniey
Copy link
Member

@conniey conniey commented Oct 1, 2016

  • Update ApiPort.Core to .NETCoreApp
  • Update README

Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a question about removing the app.config

@@ -93,9 +93,6 @@
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<None Include="app.config">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why. I reverted that change.

@conniey conniey merged commit a22e81e into microsoft:master Oct 3, 2016
@conniey conniey deleted the fixApiPortCoreBuild branch October 3, 2016 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants