Use installed Git command line for fetching repo status #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneck inside LibGit2Sharp
…ol-integration' into user/defaultryan/git-improvements
…ol-integration' into user/defaultryan/new-status # Conflicts: # extensions/GitExtension/FileExplorerGitIntegration/Models/RepositoryWrapper.cs
ssparach
approved these changes
Jul 29, 2024
DefaultRyan
merged commit ee89ce3
into
feature/fileexplorer-sourcecontrol-integration
4 checks passed
ssparach
pushed a commit
that referenced
this pull request
Jul 31, 2024
ssparach
pushed a commit
that referenced
this pull request
Jul 31, 2024
ssparach
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
To support repositories that use VFS and other features specific to the Microsoft.git fork, we should use the Git command line for certain operations that confuse libgit2. This change converts the repository status to use the command line.
Detailed description of the pull request / Additional comments
When retrieving status on a Git repo that uses features like VFS, the vanilla libgit2 implementation does not handle this case correctly. Furthermore, the default behavior is to start walking the entire working directory, hydrating virtualized files, which defeats the smarts in the forked command line "git status" that knows to first check what files are still virtualized and don't need to be examined directly.
An upcoming change will also rework the individual file status properties to use a cached snapshot of this command line repo status. This will be easier to validate if I introduce these changes incrementally.
Validation steps performed
Added new unit tests for fetching
"System.VersionControl.CurrentFolderStatus"to validate the retrieved values.