Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading screen messages have the correct automation name. #3274

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Jun 20, 2024

Summary of the pull request

The messages on the loading screen did not have the correct name. This resulted in narrator announcing the full namespace path of the view model.

Added the automation name to the xaml.

References and relevant issues

https://task.ms/51611108

Detailed description of the pull request / Additional comments

Validation steps performed

Tested manually by selecting the items with the keyboard with narrator turned on.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
  • Telemetry compliance tasks completed for added/updated events

@dhoehna dhoehna added the Needs-Second Pull request that needs another approval label Jun 21, 2024
@krschau krschau removed the Needs-Second Pull request that needs another approval label Jun 25, 2024
@dhoehna dhoehna merged commit 76eb695 into main Jun 25, 2024
4 checks passed
@krschau krschau added this to the Dev Home 0.16 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants