Add version information to all C#/C++ binaries #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaholme
requested review from
jsidewhite,
andreww-msft,
dabhattimsft,
krschau,
EricJohnson327 and
zadesai
krschau
approved these changes
Jun 4, 2024
jaholme
commented
Jun 4, 2024
…ing newlines to end of version.h on each write
dabhattimsft
approved these changes
Jun 4, 2024
EricJohnson327
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Prior to this change Dev Home binaries reported version 1.0.0.0 for C# apps
And in the case of C++ binaries had no information:
After the change C#:
After the change c++:
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
.\build.ps1 and Visual Studio compilation succeed
PR checklist