Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information to all C#/C++ binaries #3114

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

jaholme
Copy link
Contributor

@jaholme jaholme commented Jun 4, 2024

Summary of the pull request

Prior to this change Dev Home binaries reported version 1.0.0.0 for C# apps
image

And in the case of C++ binaries had no information:
image

After the change C#:
image

After the change c++:
image

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

.\build.ps1 and Visual Studio compilation succeed

PR checklist

Copy link
Contributor

@zadesai zadesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EricJohnson327 EricJohnson327 merged commit beb2490 into main Jun 5, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/jaholme/add_binary_versions branch June 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Home binaries should have version and copyright stamps
5 participants