Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SetupFlow] On review page, immediately show tab with content #297

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[SetupFlow] On review page, immediately show tab with content #297

merged 1 commit into from
Apr 28, 2023

Conversation

florelis
Copy link
Member

Summary of the pull request

On the review page we have multiple tabs showing what is to be done for the setup. We used to always show the first tab by default, even if it didn't have content. This PR changes it so that we show the first tab that has any content. This also hides the tab for Dev Drive if it wasn't selected.

References and relevant issues

Detailed description of the pull request / Additional comments

  • Added a new property to the review tab view model that says whether it has any content
  • Changed the selection of the tab to show to happen each time we get to the review page instead of only the first one, as the selections can change
  • Used the new property from the tab view models to drive which tab to show
  • Changed the review page to hide tabs that are null, the same way we hide pages that are null from the whole flow. This allows us to skip the dev drive tab if not needed.

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@florelis
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis florelis merged commit 0dd3479 into microsoft:main Apr 28, 2023
@florelis florelis deleted the showReview branch April 28, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants