Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back to non-WAP solution and fix package size increase caused by bringing PowerToys utilities #2844

Merged
merged 3 commits into from
May 9, 2024

Conversation

dabhattimsft
Copy link
Contributor

@dabhattimsft dabhattimsft commented May 9, 2024

Summary of the pull request

Move back to non-WAP solution to fix package size increase caused by bringing up of PowerToys utilities. While initially not working, multi-app scenario seems to be working with non-WAP route after series of fixes. Non-wap route is relatively simpler and hence switching back.

Also fixes hyperv and widget bugs.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

build.ps1 builds the package.
Widgets work.
Environments work.
Utilities work.

PR checklist

@dabhattimsft dabhattimsft changed the title Move back to non-WAP solution Move back to non-WAP solution and fix package size increase caused by bringing PowerToys utilities May 9, 2024
@jaholme
Copy link
Contributor

jaholme commented May 9, 2024

Can we get this in the PI branch as well to validate everything is working end-to-end? At least yesterday I was running into ReadyToRun issues that I am not sure we have a solution for yet?

@jaholme
Copy link
Contributor

jaholme commented May 9, 2024

Fixes #2836 2836

@dabhattimsft dabhattimsft marked this pull request as ready for review May 9, 2024 23:46
@dabhattimsft dabhattimsft merged commit 548d868 into main May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing *.deps.json in final package results in processes not executing
4 participants