Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AnyCPU build configuration #2770

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Remove AnyCPU build configuration #2770

merged 10 commits into from
Apr 30, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Apr 30, 2024 •
edited
Loading

Summary of the pull request

  • Remove AnyCPU from Dev Home and SampleExtension
  • Fix broken paths in SampleExtension that prevented it from loading
  • Remove AnyCPU references from QuietBackgroundProcesses
  • Does NOT remove AnyCPU from SDK where it is used

PR checklist

@krschau krschau mentioned this pull request Apr 30, 2024
Merged
@jaholme
Copy link
Contributor

jaholme commented Apr 30, 2024

With this change can we make the changes to use CPU specific CSWin32 PInvokes? There are a couple that specifically don't support AnyCPU that are being worked around using the old DllImport syntax.

@krschau
Copy link
Collaborator Author

krschau commented Apr 30, 2024 •
edited
Loading

With this change can we make the changes to use CPU specific CSWin32 PInvokes? There are a couple that specifically don't support AnyCPU that are being worked around using the old DllImport syntax.

@jaholme I'm not familiar with where we're using these workarounds. We do still build x86, I'm not sure if that means we still need them. #2786

jsidewhite
jsidewhite approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jsidewhite jsidewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau merged commit c76db33 into main Apr 30, 2024
4 checks passed
@krschau krschau mentioned this pull request Apr 30, 2024
Open
@krschau krschau deleted the user/krschau/anycpu branch May 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoehna dhoehna dhoehna approved these changes

@jsidewhite jsidewhite jsidewhite approved these changes

@nieubank nieubank nieubank approved these changes

@jaholme jaholme Awaiting requested review from jaholme

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove AnyCPU build configuration
5 participants
@krschau @jaholme @dhoehna @jsidewhite @nieubank