Only show quiet mode view when the feature is present #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidewhite
reviewed
Apr 18, 2024
...kgroundProcesses/DevHome.QuietBackgroundProcesses.UI/Views/QuietBackgroundProcessesView.xaml
Show resolved
Hide resolved
jsidewhite
approved these changes
Apr 18, 2024
krschau
approved these changes
Apr 19, 2024
dhoehna
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Quiet mode is only supported on certain versions of Windows and should not be shown on unsupported versions.
Detailed description of the pull request / Additional comments
Switch to using IsFeaturePresent which is only set when IsQuietBackgroundProcessesFeatureEnabled is already true and the feature is actually supported by the OS.
Validation steps performed
Run Dev Home on Windows 10 to verify the card is not visible.
Confirm that the feature is never visible when toggle in experimental settings is disabled
Confirm that the feature is visible on the latest Win11 build with the experimental setting toggle enabled
PR checklist