[Customization] Make quiet mode initialization async to avoid UI delay #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
approved these changes
Apr 12, 2024
vineeththomasalex
approved these changes
Apr 12, 2024
krschau
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Make quiet mode's view model initialization async on user control loaded to avoid delays when navigating to Windows customization L1 page.
References and relevant issues
#2591
Detailed description of the pull request / Additional comments
Loading QuietBackgroundProcessesSessionManager the first time and making OOP calls during ViewModel initialization on the UI thread can cause noticeable delays when navigating to the Windows customization page.
Validation steps performed
Navigate to Windows customization and ensure UI is responsive, even while injecting a long delay in loading QuietBackgroundProcessesSessionManager or calling IsFeaturePresent, GetIsActive or GetTimeRemaining to make sure those calls do not block the UI thread.
PR checklist