Fixing accessibility for buttons in "Welcome to DevHome" page #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
krschau,
dkbennett,
EricJohnson327 and
AmelBawa-msft
krschau
approved these changes
Feb 27, 2024
vineeththomasalex
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
There was no accessible names for the buttons in the small cards of the "Welcome to DevHome" page. This PR adds it.
References and relevant issues
Detailed description of the pull request / Additional comments
As for the small cards, its buttons' contents were not simple texts, so the narrator could not narrate its name when keyboard focused. This PR adds the
AutomationProperties.Nameproperty with the same text the button has, so the narrator can explicitly narrate it.Validation steps performed
PR checklist