Fix Dashboard hang when restoring uninstalled widgets #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
changed the title
krschau
requested review from
vineeththomasalex,
dkbennett,
EricJohnson327 and
AmelBawa-msft
dhoehna
reviewed
Feb 13, 2024
dhoehna
approved these changes
Feb 13, 2024
vineeththomasalex
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
PlaceWidgetcould cause a hang or crash if the widget was deleted and then we tried to update the position viaSetPositionCustomStateAsync. This change prevents that crash by only updating state on real widgets, after they are all inserted.PlaceWidgetalso was a somewhat confusing insertion middleman, and this change removes it entirely and just usesInsertWidgetInPinnedWidgetsAsyncinstead.References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist