Screenshots for Widgets preview #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
dkbennett,
EricJohnson327 and
AmelBawa-msft
|
Would it be challenging to use hardcoded input data on existing adaptive card templates instead of showing screenshots? This allows us to benefit from latest template changes and localization. |
AmelBawa-msft
approved these changes
Jan 17, 2024
EricJohnson327
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This pull request add the preview images of the widgets for the new flow of adding a widget.
References and relevant issues
Detailed description of the pull request / Additional comments
This pull request adds two images (dark and light modes) for the previews of each widget. This images are shown when the user is about to pin a new widget.
Validation steps performed
PR checklist