Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing TextBox to use MinHeight instead of Height to fix 200% font scaling #2112

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

guimafelipe
Copy link
Contributor

@guimafelipe guimafelipe commented Jan 9, 2024

Summary of the pull request

Changing TextBox to use MinHeight instead of Height to get the placeholder text and input to not be clipped when higher font scale is selected by the user.
image

References and relevant issues

https://dev.azure.com/microsoft/OS/_workitems/edit/48138266

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@guimafelipe guimafelipe added the Needs-Second Pull request that needs another approval label Jan 9, 2024
@dkbennett dkbennett removed the Needs-Second Pull request that needs another approval label Jan 10, 2024
@krschau krschau merged commit 49a8bef into main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants