Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all selected applications #1626

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

hamnarauf
Copy link
Contributor

@hamnarauf hamnarauf commented Sep 30, 2023

Summary of the pull request

Implemented a "Remove All" button to clear all the selected applications in setup flow.

References and relevant issues

#1625

Detailed description of the pull request / Additional comments

  1. Added "Remove all" button in UI
  2. Implemented remove all functionality in RemoveAllPackages to clear all selected applications
  3. Ensured that the button is only enabled when at least one application is selected

Validation steps performed

Dev Home (Dev) 2023-09-30 17-06-57_Trim (1)

PR checklist

@bbonaby
Copy link
Contributor

bbonaby commented Oct 2, 2023

@AmelBawa-msft figured I'd let you do a first pass on this? Do you think we need to involve Ian with this?

@AmelBawa-msft
Copy link
Contributor

Adding @ianyyu to help review the suggested change. Note: we're removing the 'Add all' button soon as part of removing the carousel in app install page.

@cinnamon-msft
Copy link
Contributor

I don't think we need a design pass here. I'd rather us get this merged in and do a design pass later :) @AmelBawa-msft @bbonaby

@crutkas
Copy link
Member

crutkas commented Dec 15, 2023

I agree with @cinnamon-msft

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending @EricJohnson327's testing

@EricJohnson327 EricJohnson327 merged commit cb99883 into microsoft:main Jan 12, 2024
1 check passed
@hamnarauf hamnarauf deleted the removeAll branch January 12, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all selected applications
8 participants